Release v0.1.11 #51
clippy
6 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 6 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.2 (25ef9e3d8 2024-04-09)
- cargo 1.77.2 (e52e36006 2024-03-26)
- clippy 0.1.77 (25ef9e3 2024-04-09)
Annotations
Check warning on line 146 in src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:146:38
|
146 | let go_version = get_version(&go_path_str)?;
| ^^^^^^^^^^^^ help: change this to: `go_path_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 131 in src/main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/main.rs:131:13
|
131 | return Ok::<i32, anyhow::Error>(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
131 - return Ok::<i32, anyhow::Error>(0);
131 + Ok::<i32, anyhow::Error>(0)
|
Check warning on line 98 in src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/main.rs:98:23
|
98 | match backup_file(&file_path) {
| ^^^^^^^^^^ help: change this to: `file_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 84 in src/utils.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/utils.rs:84:23
|
84 | let url = build_url(&download_url, &path);
| ^^^^^^^^^^^^^ help: change this to: `download_url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 18 in src/download.rs
github-actions / clippy
file opened with `create`, but `truncate` behavior not defined
warning: file opened with `create`, but `truncate` behavior not defined
--> src/download.rs:18:6
|
18 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
Check warning on line 92 in src/main.rs
github-actions / clippy
unneeded unit return type
warning: unneeded unit return type
--> src/main.rs:92:39
|
92 | fn backup_or_fail(file_path: &PathBuf) -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default