This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
… and `svm_alloc`)
neysofu
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
verify
stage as part of the Runtime interface.More in-depth information about why need that functionality appears in the Account Unification SMIP.
Notes
Verify Data
to denote the ABI encoded data given as input for theverify
function.Call Data
to denote the ABI encoded data given when running the Transaction function.VerifyData
andCallData
share the same mechanism, parts of the code simply use the termInput Data
.In order not to bloat this PR, there are still code parts that use the term
Call Data
but gradually they will be renamed to useInput Data
.verify
returns aCallReceipt
. It means thatverify
can return any blob of data (a.k.a thereturndata
).Whether the
verify
will return only a boolean is still in research.verify
is expected to work with no access to the Account's storage. In other words, only pure logiccan take place within
verify
. See issue: AA: Protected Mode forverify
#327