You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am looking through the code trying to get to the bottom of #455 and the tangled web of how the APE 14 API calls the __call__ and invert methods which also have their own API semantics is driving me round the bend. Therefore I have the following proposal:
Refactor the existing code so that there is an "internal" forward and backward transform method with a very restrictive API. (Takes Quantity if the transform uses quantities and returns whatever the transform returns, some extra handling for numerical inverse etc).
Keep the current __call__ and invert methods and deprecate them.
Rework the APE 14 API methods so that they do any required pre- or post-processing before calling the "internal" forward and backward methods.
We could keep the old API deprecated for a long time (we don't even have to make it raise warnings or anything at this point), but I feel like there's no need to keep around both sets of API for a package which hasn't hit 1.0 yet?
The text was updated successfully, but these errors were encountered:
Cadair
changed the title
Deprecate the non-ape 14 API
Deprecate the pre-APE 14 API
Jun 14, 2023
I am looking through the code trying to get to the bottom of #455 and the tangled web of how the APE 14 API calls the
__call__
andinvert
methods which also have their own API semantics is driving me round the bend. Therefore I have the following proposal:__call__
andinvert
methods and deprecate them.We could keep the old API deprecated for a long time (we don't even have to make it raise warnings or anything at this point), but I feel like there's no need to keep around both sets of API for a package which hasn't hit 1.0 yet?
The text was updated successfully, but these errors were encountered: