Skip to content

Commit

Permalink
show unit cols by default in model fitting results table (#3196)
Browse files Browse the repository at this point in the history
* show unit cols by default in model fitting results table - especially useful now that switching input units is supported
  • Loading branch information
kecnry authored Sep 23, 2024
1 parent 7391556 commit 32bb09e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ New Features

- New configuration for ramp/Level 1 data products from Roman WFI and JWST [#3120, #3148, #3167, #3171]

- Unit columns are now visible by default in the results table in model fitting. [#3196]

Cubeviz
^^^^^^^

Expand Down
4 changes: 2 additions & 2 deletions jdaviz/configs/default/plugins/model_fitting/model_fitting.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ def __init__(self, *args, **kwargs):

self.table.headers_avail = headers
self.table.headers_visible = headers
# when model parameters are added as columns, only show the value columns by default
# when model parameters are added as columns, only show the value/unit columns by default
# (other columns can be show in the dropdown by the user)
self.table._new_col_visible = lambda colname: colname.split(':')[-1] not in ('unit', 'fixed', 'uncert', 'std') # noqa
self.table._new_col_visible = lambda colname: colname.split(':')[-1] not in ('fixed', 'uncert', 'std') # noqa

# set the filter on the viewer options
self._update_viewer_filters()
Expand Down

0 comments on commit 32bb09e

Please sign in to comment.