Skip to content

Commit

Permalink
addressing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bmorris3 committed Sep 27, 2024
1 parent f0f44cf commit 5a0e861
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ New Features

- The standalone version of jdaviz now uses solara instead of voila, resulting in faster load times. [#2909]

- New configuration for ramp/Level 1 data products from Roman WFI and JWST [#3120, #3148, #3167, #3171, #3194]
- New configuration for ramp/Level 1 and rate image/Level 2 data products from Roman WFI and
JWST [#3120, #3148, #3167, #3171, #3194]

- Unit columns are now visible by default in the results table in model fitting. [#3196]

Expand Down
4 changes: 2 additions & 2 deletions jdaviz/configs/rampviz/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@ def create_image_viewer(self, viewer_name=None, data=None):
Image viewer instance.
"""
from jdaviz.configs.imviz.plugins.viewers import ImvizImageView
from jdaviz.configs.rampviz.plugins.viewers import RampvizImageView

Check warning on line 117 in jdaviz/configs/rampviz/helper.py

View check run for this annotation

Codecov / codecov/patch

jdaviz/configs/rampviz/helper.py#L117

Added line #L117 was not covered by tests

# Cannot assign data to real Data because it loads but it will
# not update checkbox in Data menu.

return self.app._on_new_viewer(

Check warning on line 122 in jdaviz/configs/rampviz/helper.py

View check run for this annotation

Codecov / codecov/patch

jdaviz/configs/rampviz/helper.py#L122

Added line #L122 was not covered by tests
NewViewerMessage(ImvizImageView, data=None, sender=self.app),
NewViewerMessage(RampvizImageView, data=None, sender=self.app),
vid=viewer_name, name=viewer_name)
5 changes: 4 additions & 1 deletion jdaviz/configs/rampviz/plugins/viewers.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ def _initial_x_axis(self, *args):
ref_data = self.state.reference_data

if ref_data:
self.state.x_att = ref_data.id["Pixel Axis 0 [z]"]
if "Pixel Axis 0 [z]" in [comp.label for comp in ref_data.components]:
self.state.x_att = ref_data.id["Pixel Axis 0 [z]"]
else:
self.state.x_att = ref_data.id["Pixel Axis 0 [y]"]

Check warning on line 137 in jdaviz/configs/rampviz/plugins/viewers.py

View check run for this annotation

Codecov / codecov/patch

jdaviz/configs/rampviz/plugins/viewers.py#L137

Added line #L137 was not covered by tests

def set_plot_axes(self):
self.figure.axes[1].tick_format = None
Expand Down

0 comments on commit 5a0e861

Please sign in to comment.