Apply suggestions from code review

spacetelescope · Sep 30, 2024 · 7610f50 · 7610f50
1 parent 3ab4e03
commit 7610f50
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py b/jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py
@@ -59,7 +59,7 @@
     'andnot': AndNotMode,
 }
 SUBSET_TO_PRETTY = {v: k for k, v in SUBSET_MODES_PRETTY.items()}
-COMBO_OPTIONS = ['new', 'replace', 'or', 'and', 'xor', 'andnot']
+COMBO_OPTIONS = list(SUBSET_MODES_PRETTY.keys())
 
 
 @tray_registry('g-subset-plugin', label="Subset Tools")
@@ -132,11 +132,10 @@ def __init__(self, *args, **kwargs):
         align_by = getattr(self.app, '_align_by', None)
         self.display_sky_coordinates = (align_by == 'wcs' and not self.multiselect)
 
-        combination_options = list(SUBSET_MODES_PRETTY)
         self.combination_mode = SelectPluginComponent(self,
                                                       items='combination_items',
                                                       selected='combination_selected',
-                                                      manual_options=combination_options)
+                                                      manual_options=COMBO_OPTIONS)
 
     @property
     def user_api(self):