Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specviz notebook uses deprecated load_spectrum #2350

Closed
Jdaviz-Triage-Bot opened this issue Aug 8, 2023 · 0 comments · Fixed by #2373
Closed

Specviz notebook uses deprecated load_spectrum #2350

Jdaviz-Triage-Bot opened this issue Aug 8, 2023 · 0 comments · Fixed by #2373
Labels
bug Something isn't working documentation Explanation of code and concepts specviz

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Aug 8, 2023 •
edited by pllim
Loading

Reporter: pllim

I noticed this but is deep in a rabbit hole, so opening a ticket instead.

jdaviz/notebooks/SpecvizExample.ipynb

Line 111 in 4c0a4c0

"specviz.load_spectrum(f'{data_dir}/{fn}', \"myfile\")"

Change load_spectrum to load_data . Needs to be backported. Deprecated in #2273

🐱

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
@pllim pllim added bug Something isn't working documentation Explanation of code and concepts specviz labels Aug 8, 2023
@pllim pllim mentioned this issue Aug 14, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Explanation of code and concepts specviz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT: Stop mentioning load_spectrum because it was deprecated in 3.6 pllim/jdaviz
2 participants
@pllim @Jdaviz-Triage-Bot