-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace load_spectrum with load_data #2273
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.03%
==========================================
Files 150 150
Lines 16848 16849 +1
==========================================
- Hits 15390 15387 -3
- Misses 1458 1462 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devdeps failure is unrelated. LGTM but I will refrain from approving until we have that change log because I don't want this to get accidentally merged without one. Thanks!
def load_spectrum(self, data, data_label=None, format=None, show_in_viewer=True, | ||
concat_by_file=False): | ||
""" | ||
Loads a data file or `~specutils.Spectrum1D` object into Specviz. | ||
|
||
Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a little too late the improve load_spectrum
doc now? 😆 Doesn't hurt though...
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally!!!! Thanks!
Thanks for the reviews! Merging |
Description
This pull request brings specviz in line with the other viz tools by deprecating
specviz.load_data
and replacing it withspecviz.load_data
. I think I got all the documentation changes as well here. Should be pretty uncontroversial, as we've been asking for this for a long timeThe decreased coverage is due to the deprecated method
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.