-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements to is_active ping logic #2450
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Tested where I was seeing the flickering (it is a notebook where I first load a bunch of spectra in mosviz and then I load one in specviz2d) and it is gone. Works well, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving by proxy based on Cami's comment. Thanks!
Up to you if you want to add a change log since I don't think this flicker shows up for everyone? |
I'm still hoping to come up with a robust regression test for this (which is why I'm keeping it in draft), but its not an easy thing to test. |
* fixes case where method call taking longer than ping timeout results in flashing
including retroactive changelog for spacetelescope#2386 which this builds on
f9b2c66
to
4f98b8d
Compare
Re-milestoned to 3.7 since this builds on #2386 which was not backported and we're likely not doing a 3.6.3 release anyways. I was not successful in creating a proper regression test, but am including some test infrastructure/coverage for the active pings anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried in Imviz and Mosviz and couldn't replicate the original bug. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't grok the test but something is better than nothing. My approval stands. Thanks!
* add to skip list before running method - fixes case where method call taking longer than ping timeout results in flashing * ping test coverage
Description
This pull request aims fix lag and "flickering" issues within the
is_active
ping logic, hopefully for the last time 🤞 .See:
TODO:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.