-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Observatory plugin for Jdaviz #2872
Open
duytnguyendtn
wants to merge
64
commits into
spacetelescope:main
Choose a base branch
from
duytnguyendtn:vo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
a8a458e
Migrate VO plugin to Jdaviz
duytnguyendtn b4c3530
Print resource url in empty error
duytnguyendtn 3b6ffa6
Clarify degree unit on coord tooltip
duytnguyendtn 0d688d9
Catch connection error
duytnguyendtn 945677c
Allow URL only override
duytnguyendtn 83fa048
Automatically fallback table to URL-only if unable to get metadata co…
duytnguyendtn abb24ec
Coordinate frame option
duytnguyendtn bb41ee5
Autocenter coords on viewer if data present
duytnguyendtn 7fffc8f
Filter resource querying on coverage at source, adjust userflow to se…
duytnguyendtn 1c67aca
Coverage filtering toggle
duytnguyendtn bf4a94f
Migrate resource_selected to v-model
duytnguyendtn 6a555f9
Mark Source and Resource as required fields
duytnguyendtn 9348eef
Remove redundant manual traitlet sync
duytnguyendtn d580c66
Set throwaway event args to optional
duytnguyendtn 4e18af2
Drop vestigial argument signatures
duytnguyendtn 76581ca
Set query registry to observe waveband_selected to avoid multiple reg…
duytnguyendtn 81e6cb1
Add TODO comment
duytnguyendtn ca41b24
Black Formatting
duytnguyendtn 9d007b8
First draft documentation
duytnguyendtn a3295ce
Fix doc references
duytnguyendtn 09a21bb
Fix IVOA hyperlink
duytnguyendtn d22ddd7
Docs: Add mention to source name string input
duytnguyendtn c0ecc2a
Local autocenter test
duytnguyendtn 2ca1cbf
Coverage toggle test
duytnguyendtn a357e83
Move table population to testable method for local test
duytnguyendtn 5ddd663
Test Formatting
duytnguyendtn 96b93c1
Add custom table header test
duytnguyendtn e023d91
Switch to direct URL loading
duytnguyendtn ab8ae95
Add M51 load data test
duytnguyendtn a5e9970
Add SIA2 warning
duytnguyendtn bbce480
Don't use cache to avoid loadtime warning
duytnguyendtn c4146dc
Filter known data product warnings in load_data test
duytnguyendtn c19d01f
Document unit tests
duytnguyendtn c884c69
Codestyle
duytnguyendtn 4f3a967
Changelog
duytnguyendtn a18101c
Properly compare autocenter coord values as floats
duytnguyendtn 8ecce9e
URL fallback needs to reset current entry to URL only if previous att…
duytnguyendtn f9cf202
Table header URL fallback test
duytnguyendtn 3ac2a7c
Fix CSS height arg
duytnguyendtn 08f3696
Drop vestigial ICRS frame requirement in tooltip
duytnguyendtn 5b6eeef
Codestyle
duytnguyendtn c41b72f
Syntax fix
duytnguyendtn 606d6a8
Only lookup source coordinate in registry query IF coverage filtering…
duytnguyendtn 9b6a60b
Define center coordinates as attr for reference in other tests
duytnguyendtn aebd564
Only block registry querying if no source and filtering enabled. Allo…
duytnguyendtn 437d395
Clear source field if autocoord viewer has no data
duytnguyendtn 00b0da1
Test comments
duytnguyendtn dc5a4de
Test for source error snackbar messages
duytnguyendtn b9aa8e1
Disable registry coverage filtering by default (per Cami request)
duytnguyendtn c250c1f
Test load data error messages
duytnguyendtn 10d712d
Warn users about potentially misaligned data if WCS linking isn't ena…
duytnguyendtn d4f152a
Load data errors do not prevent subsequent data products from loading
duytnguyendtn e2e463d
Test organization, codestyle
duytnguyendtn 49eefb7
Test that loading spinners turn off when operations are complete
duytnguyendtn 5a61cc9
Effectively disable timeout
duytnguyendtn c0e9086
Recalculate autocoord when linktype changes
duytnguyendtn ea2562e
Allow float degrees
duytnguyendtn 783262a
Add support for radius units
duytnguyendtn 5742480
Use UnitSelectPluginComponent for radius unit
duytnguyendtn 03a00e3
Add viewer force recenter button
duytnguyendtn 300f194
Allow plugin to follow viewer coords thru panning
duytnguyendtn 8898c55
Don't bother subscribing if we're on Manual
duytnguyendtn 0ff66b1
Update test method call after renaming
duytnguyendtn fd89b64
UI: Change autocenterbtn icon to indicate when coords are centered or…
duytnguyendtn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,6 +108,11 @@ const tooltips = { | |
'plugin-dq-show-all': 'Show all quality flags', | ||
'plugin-dq-hide-all': 'Hide all quality flags', | ||
'plugin-dq-color-picker': 'Change the color of this DQ flag', | ||
'plugin-vo-filter-coverage': `Only show surveys that report coverage within specified radius of provided coordinates. Queries may take longer to process<br /><br /> | ||
<div style="border: 1px solid gray;" class="pa-2"> | ||
<strong>Note:</strong> | ||
Surveys which have not implemented coverage information will also be excluded. If you are expecting a survey that doesn't appear, try disabling coverage filtering. | ||
</div>` | ||
Comment on lines
+112
to
+115
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can this have a max-width or something set? Right now this results in an extremely wide tooltip which might not fit at smaller resolutions, etc. |
||
} | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from .vo_plugin import * # noqa |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! 😬