Fix cube fit toggle with spectral subset selected #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 88.93% 88.88% -0.06%
==========================================
Files 112 112
Lines 17411 17391 -20
==========================================
- Hits 15485 15458 -27
- Misses 1926 1933 +7 ☔ View full report in Codecov by Sentry. |
kecnry
approved these changes
Jul 31, 2024
haticekaratay
approved these changes
Jul 31, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where toggling to Cube Fit in the model fitting plugin when a spectral subset was selected would result in a traceback and no data being available in the dataset menu. It appears that the dataset is briefly set to None in this case before the appropriate cube data is populated in the menu.