Backport PR #3123 on branch v3.10.x (Fix cube fit toggle with spectral subset selected) #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeseeksmachine
requested review from
rosteen,
javerbukh,
pllim,
kecnry and
bmorris3
as code owners
lumberbot-app
bot
added
the
plugin
pllim
approved these changes
Jul 31, 2024
|
I should have paid more attention during the original PR - is this confirmed as a bug in 3.10 and not just main? |
|
The behavior for the cube toggle was changed in #2827 which is milestoned as 4.0, so even though the diff seems to be able to backport, I'm not sure that the bug was present until then 🤔 |
|
I'll double check. |
|
You're right, I milestoned that PR incorrectly. I'll close this and open a quick PR to move the changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #3123: Fix cube fit toggle with spectral subset selected