Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslatable unit handling #3139

Merged
merged 14 commits into from
Aug 19, 2024

resolve failing tests and spectral extraction issue

d3ec377
Select commit
Loading
Failed to load commit list.
Merged

Untranslatable unit handling #3139

resolve failing tests and spectral extraction issue
d3ec377
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 16, 2024 in 1s

91.66% of diff hit (target 90.00%)

View this Pull Request on Codecov

91.66% of diff hit (target 90.00%)

Annotations

Check warning on line 193 in jdaviz/configs/specviz/plugins/unit_conversion/unit_conversion.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jdaviz/configs/specviz/plugins/unit_conversion/unit_conversion.py#L193

Added line #L193 was not covered by tests

Check warning on line 394 in jdaviz/utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jdaviz/utils.py#L393-L394

Added lines #L393 - L394 were not covered by tests

Check warning on line 400 in jdaviz/utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jdaviz/utils.py#L399-L400

Added lines #L399 - L400 were not covered by tests

Check warning on line 432 in jdaviz/utils.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jdaviz/utils.py#L432

Added line #L432 was not covered by tests