Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untranslatable unit handling #3139

Merged
merged 14 commits into from
Aug 19, 2024
Merged

Untranslatable unit handling #3139

merged 14 commits into from
Aug 19, 2024

Commits on Aug 16, 2024

  1. re-add untranslatable units, add translation equivalencies

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    93dfeeb View commit details
    Browse the repository at this point in the history

  2. readd untranslatable units to app defined units

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    aac6d69 View commit details
    Browse the repository at this point in the history

  3. fix rebase, enable untranslatable units, testing and coords needs work

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1133638 View commit details
    Browse the repository at this point in the history

  4. fix styling

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d9f8fea View commit details
    Browse the repository at this point in the history

  5. resolve spectrum-viewer mouseover, image-viewers need work

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6058671 View commit details
    Browse the repository at this point in the history

  6. generalize flux_conversion, enable untranslatable units, temporarily … 

    …us mouseover global messages
    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8f07658 View commit details
    Browse the repository at this point in the history

  7. change log entry, update test_utils.py tests

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2c0a3b4 View commit details
    Browse the repository at this point in the history

  8. increase test coverage

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e066482 View commit details
    Browse the repository at this point in the history

  9. seperate flux conversion and transitive units, remove duplicate units… 

    …, test coverage
    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    89d1c87 View commit details
    Browse the repository at this point in the history

  10. remove duplicate/reversed units

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    03736db View commit details
    Browse the repository at this point in the history

  11. implement commented changes

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    43272fd View commit details
    Browse the repository at this point in the history

  12. update tests

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    12fb37c View commit details
    Browse the repository at this point in the history

  13. address review comments, begin work on spectral extraction issue

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ea76c26 View commit details
    Browse the repository at this point in the history

  14. resolve failing tests and spectral extraction issue

    @gibsongreen
    gibsongreen committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d3ec377 View commit details
    Browse the repository at this point in the history