Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alert when function and spectral y-units are inconsistent #3143

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 8, 2024

Description

As a follow-up to #3142, this pull request adds an in-line alert within the spectral extraction plugin when the currently selected function would natively result in units inconsistent with those shown on the y-axis of the spectrum viewer.

Screen.Recording.2024-08-08.at.3.51.46.PM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.0 milestone Aug 8, 2024
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Aug 8, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (6009e66) to head (942ae49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   88.81%   88.82%           
=======================================
  Files         112      112           
  Lines       17427    17436    +9     
=======================================
+ Hits        15478    15487    +9     
  Misses       1949     1949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review August 9, 2024 11:52
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in combination with #3142 removing the snackbar message!

@kecnry kecnry merged commit e6bd383 into spacetelescope:main Aug 13, 2024
19 checks passed
@kecnry kecnry deleted the spec-extract-alert branch August 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants