Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update unit conversion message responses in plugins, add tests #3144
base: main
Are you sure you want to change the base?
update unit conversion message responses in plugins, add tests #3144
Changes from all commits
cddd7a8
63f895d
a34fa0b
bfca6aa
d88a49b
8f5cf54
b2bd693
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably needs some logic to skip if the
msg.axis
is not eitherspectral
orspectral_y
(could be by checking ifaxis
isNone
after the get, or rewriting this intoif, elif, else: return
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason this can't use the
self.flux_or_sb
switch instead ofself.spectrum_viewer.state.y_display_unit
(maybe @gibsongreen would have some context on that as well)? That could be done as a follow-up if its out of scope.Either way, maybe we rename the variable to
spectral_y
to be consistent with the message that is broadcast from this and to avoid confusion with the switch itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should work, the traitlet for
self.flux_or_sb
at this point in the function should still match that flux or surface brightness selection for the value ofself.spectrum_viewer.state.y_display_unit/spectral_y/current_y_unit