Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: photutils nightly wheel, devdeps clean-up #3145

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 10, 2024

Description

This pull request is to use photutils nightly wheel (astropy/photutils#1834) and also some clean-up to devdeps setup.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

and devdeps clean-up
@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive Build standalone Additional pylons labels Aug 10, 2024
@pllim pllim added this to the 4.0 milestone Aug 10, 2024
@pllim pllim marked this pull request as ready for review August 10, 2024 01:30
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (f5c93ab) to head (43228d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3145   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         112      112           
  Lines       17550    17550           
=======================================
  Hits        15588    15588           
  Misses       1962     1962           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Aug 10, 2024

Standalone build failure is unrelated.

@pllim pllim merged commit 3bf4223 into spacetelescope:main Aug 13, 2024
32 of 38 checks passed
@pllim pllim deleted the photutils-nightly branch August 13, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build standalone Additional pylons no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants