Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecessary stretch histogram updates #3151

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 14, 2024

Description

This pull request removes unnecessary updates to the stretch histogram triggered by callbacks on the zoom-limits when the stretch histogram is not set to be restricted to current zoom-limits.

Fixes #3146

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

to include logic to skip callback when histogram is not set to follow zoom-limits
@kecnry kecnry added the backport-v3.10.x on-merge: backport to v3.10.x label Aug 14, 2024
@kecnry kecnry added this to the 3.10.4 milestone Aug 14, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Aug 14, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, and can no longer reproduce the bad behavior. Good catch!

@rosteen
Copy link
Collaborator

rosteen commented Aug 14, 2024

Still works for me after the changes, my review stands.

@kecnry kecnry marked this pull request as ready for review August 14, 2024 18:36
@pllim pllim merged commit 881679f into spacetelescope:main Aug 14, 2024
17 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Aug 14, 2024
@kecnry kecnry deleted the stretch-hist-performance branch August 14, 2024 18:51
pllim added a commit that referenced this pull request Aug 14, 2024
…1-on-v3.10.x

Backport PR #3151 on branch v3.10.x (fix unnecessary stretch histogram updates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.10.x on-merge: backport to v3.10.x plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot options histogram infinite loops after scrolling away
3 participants