Skip flux conversion for moment maps #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
|
Whoops, it almost certainly does. I should have stuck to fixing the first bug I found 😆 |
|
I could split out the changes to |
rosteen
force-pushed
the
fix-moment-mouseover-again
branch
from
24adaa6
to
04d321c
Compare
kecnry
approved these changes
Aug 22, 2024
Comment on lines
+488
to
+499
| if str(u.Unit(unit).physical_type) not in ("spectral flux density", | ||
| "surface brightness"): | ||
| skip_spectral_density_eqv = True |
There was a problem hiding this comment.
if this is the only exception, this probably could be shortened to be directly in the if-statement itself, but that's probably a matter of preference.
|
There is a conflict. Please rebase. |
rosteen
force-pushed
the
fix-moment-mouseover-again
branch
from
04d321c
to
535727f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3158 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 122 122
Lines 18264 18267 +3
=======================================
+ Hits 16150 16153 +3
Misses 2114 2114 ☔ View full report in Codecov by Sentry. |
cshanahan1
pushed a commit
to cshanahan1/jdaviz
that referenced
this pull request
Sep 9, 2024
* Skip flux conversion for moment maps * More general check on unit physical type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #3139 broke adding moment maps to a viewer, due to the
coords_infologic. This skips the flux conversion that breaks it in the case of moment-like units (velocity and higher powers of it) by skipping any unit with incompatible physical type.Additionally, calculating moment 0 in flux when the cube is in surface brightness seemed to be broken (again?) so I moved the unit conversion to be before the moment calculation, so we can convert, e.g., MJy/sr to MJy and not have to worry about the extra wavelength unit that comes in via the moment calculation.I also took this opportunity to bump the specutils pin and get rid of the handling for the change in 1.16 for the dev tests and such.