-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Update remote data result for DQ plugin #3161
Conversation
with pipeline changes
jdaviz/configs/default/plugins/data_quality/tests/test_data_quality.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/default/plugins/data_quality/tests/test_data_quality.py
Outdated
Show resolved
Hide resolved
…ality.py Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
Does this test exist on 3.10 and need to be backported? |
Yes. |
Do we still care about v3.10? I thought we're going for v4.0. |
Thanks for the reviews! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 112 112
Lines 17626 17627 +1
=======================================
+ Hits 15657 15658 +1
Misses 1969 1969 ☔ View full report in Codecov by Sentry. |
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Description
Probably caused by pipeline changes we can do nothing about. One of the dangers of remote data tests.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.