Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update remote data result for DQ plugin #3161

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 21, 2024

Description

Probably caused by pipeline changes we can do nothing about. One of the dangers of remote data tests.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Aug 21, 2024
@pllim pllim added this to the 4.0 milestone Aug 21, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Aug 21, 2024
…ality.py

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
@kecnry
Copy link
Member

kecnry commented Aug 21, 2024

Does this test exist on 3.10 and need to be backported?

@bmorris3
Copy link
Contributor

Does this test exist on 3.10 and need to be backported?

Yes.

@bmorris3 bmorris3 added the backport-v3.10.x on-merge: backport to v3.10.x label Aug 21, 2024
@pllim
Copy link
Contributor Author

pllim commented Aug 21, 2024

Do we still care about v3.10? I thought we're going for v4.0.

@pllim pllim modified the milestones: 4.0, 3.10.4 Aug 21, 2024
@pllim pllim enabled auto-merge (squash) August 21, 2024 19:54
@pllim
Copy link
Contributor Author

pllim commented Aug 21, 2024

Thanks for the reviews!

@pllim pllim merged commit 43f2bb0 into spacetelescope:main Aug 21, 2024
25 of 26 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (95d6008) to head (783a25c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3161   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         112      112           
  Lines       17626    17627    +1     
=======================================
+ Hits        15657    15658    +1     
  Misses       1969     1969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kecnry pushed a commit that referenced this pull request Aug 21, 2024
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@pllim pllim deleted the fix-test-dq branch August 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.10.x on-merge: backport to v3.10.x no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants