Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo from PR 3159 #3165

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix typo from PR 3159 #3165

merged 1 commit into from
Aug 22, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 22, 2024

Description

This pull request fixes a typo introduced in #3159 causing the spectral extraction UI in cubeviz to fail to render.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Aug 22, 2024
@kecnry kecnry added this to the 4.0 milestone Aug 22, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Aug 22, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you on this one (although maybe I shouldn't! 😆 )

@kecnry
Copy link
Member Author

kecnry commented Aug 22, 2024

Clearly not, that's how we got here in the first place! 😜

@kecnry kecnry enabled auto-merge (squash) August 22, 2024 18:07
@kecnry kecnry merged commit 24a4a66 into spacetelescope:main Aug 22, 2024
30 of 32 checks passed
@kecnry kecnry deleted the 3159-typo-fix branch August 22, 2024 18:43
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (0c63463) to head (a0319b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   87.20%   87.20%   -0.01%     
==========================================
  Files         121      121              
  Lines       18239    18239              
==========================================
- Hits        15906    15905       -1     
- Misses       2333     2334       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cshanahan1 pushed a commit to cshanahan1/jdaviz that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants