Debug Cubeviz batch photometry (backport #3163 onto v3.10.x) #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Debugging Cubeviz batch photometry * Fix changing units when in batch mode * Working on adding cubeviz batch photometry test * Add simple test * Codestyle * Add comment about future changes * Move changelog to 3.10.4 * Don't convert if display unit hasn't been initialized * Update test * Codestyle * Update jdaviz/configs/imviz/plugins/aper_phot_simple/aper_phot_simple.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> (cherry picked from commit 19a8f56)
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
pllim
approved these changes
Sep 5, 2024
pllim
changed the title
|
Looks like this backport is incomplete. Given we want to release v4.0 soon, is this really worth the trouble?
|
I'm a step ahead of you, just added that fixture 😁 |
|
Ahh but there's another failure. Maybe not worth the trouble. |
|
Yeah. Not worth it. Thanks for trying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the non-unit-conversion related parts of #3163 to fix Cubeviz batch photometry in 3.10.x.