require specutils >= 1.16.0 #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay and
gibsongreen
as code owners
github-actions
bot
added
cubeviz
plugin
pllim
approved these changes
Sep 6, 2024
|
(disabled auto merge since code style is failing - although then realized it probably wouldn't have merged with that failure anyways) |
kecnry
reviewed
Sep 6, 2024
cshanahan1
force-pushed
the
specutils_16
branch
from
777a050
to
f9026ad
Compare
cshanahan1
force-pushed
the
specutils_16
branch
from
f9026ad
to
c96166b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 124 124
Lines 18347 18349 +2
==========================================
Hits 16221 16221
- Misses 2126 2128 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes version check in moment map tests and require specutils >=1.16.0