Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cube fitting compatibility with unit conversion #3190

Merged
merged 22 commits into from
Sep 20, 2024
Merged

Fix cube fitting compatibility with unit conversion #3190

merged 22 commits into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. Fix NaN handling in cube fitting and initial fixes for unit conversio… 

    …n/model fitting interaction
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    645c254 View commit details
    Browse the repository at this point in the history

  2. Remove debugging prints, add comment for context

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    79081d1 View commit details
    Browse the repository at this point in the history

  3. Codestyle, changelog

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7520892 View commit details
    Browse the repository at this point in the history

  4. Reestimate parameters when cube fitting is toggled

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d0823b View commit details
    Browse the repository at this point in the history

  5. Only reestimate if spectral y type isn't SB

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ee5a108 View commit details
    Browse the repository at this point in the history

  6. Codestyle

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c94ef87 View commit details
    Browse the repository at this point in the history

  7. Changelog

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c24b6c2 View commit details
    Browse the repository at this point in the history

  8. Fix initializing linear component for cube fit

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dabcc84 View commit details
    Browse the repository at this point in the history

  9. Handle linear component estimation for cube case

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a7046c4 View commit details
    Browse the repository at this point in the history

  10. Only reshape here in 3D case

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a42173c View commit details
    Browse the repository at this point in the history

  11. Skip tests that need spacetelescope#3156

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f405609 View commit details
    Browse the repository at this point in the history

  12. Respect selected display units when initializing model components

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d8972b3 View commit details
    Browse the repository at this point in the history

  13. Use app._get_display_unit instead of relying on Unit Conversion

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fcba42b View commit details
    Browse the repository at this point in the history

  14. Add equivalency here

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9abc3bf View commit details
    Browse the repository at this point in the history

  15. Only reestimate here if sb unit != spectral_y unit

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4a1a10f View commit details
    Browse the repository at this point in the history

  16. Don't automatically reestimate when toggling cube fit, make the user … 

    …do it
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5a0b525 View commit details
    Browse the repository at this point in the history

  17. Remove print

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a50c940 View commit details
    Browse the repository at this point in the history

  18. Check for warning in test after cube toggle 

    Fix test

Codestyle
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d3dbcd9 View commit details
    Browse the repository at this point in the history

  19. Add test for cube fitting after flux unit change

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    529bb74 View commit details
    Browse the repository at this point in the history

  20. Add a to-do about a test for unit conversion with equivalency

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    35d2d96 View commit details
    Browse the repository at this point in the history

  21. Fix failing test

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f46e9d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Back to parallel processing post-debugging

    @rosteen
    rosteen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b33dcc0 View commit details
    Browse the repository at this point in the history