Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor unit conversion messaging #3192

Merged
merged 22 commits into from
Sep 26, 2024
Merged

refactor unit conversion messaging #3192

merged 22 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. WIP: refactor/simplify messaging and logic in unit conversion

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0abc22b View commit details
    Browse the repository at this point in the history

  2. generalized solution in place of spacetelescope#3185

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    452eb5e View commit details
    Browse the repository at this point in the history

  3. code cleanup

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a1b5bae View commit details
    Browse the repository at this point in the history

  4. generalized solution in place of spacetelescope#3177

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5bd8241 View commit details
    Browse the repository at this point in the history

  5. update slice plugin to handle new messaging order

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    186868a View commit details
    Browse the repository at this point in the history

  6. generalize initializing options to also act on first valid data

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    58e9d63 View commit details
    Browse the repository at this point in the history

  7. code cleanup

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9607eb4 View commit details
    Browse the repository at this point in the history

  8. fix test failures

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cc43f45 View commit details
    Browse the repository at this point in the history

  9. Revert "skip test in parsers" 

    This reverts commit aa0d384.
    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    72b4677 View commit details
    Browse the repository at this point in the history

  10. fix rebase failure

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    08cb09c View commit details
    Browse the repository at this point in the history

  11. unskip test

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    029955c View commit details
    Browse the repository at this point in the history

  12. replace time axis elif with comment

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8fb3d5d View commit details
    Browse the repository at this point in the history

  13. add e/s

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7a2fef7 View commit details
    Browse the repository at this point in the history

  14. changelog entry

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    51e2f70 View commit details
    Browse the repository at this point in the history

  15. revert debugging separation

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    08611aa View commit details
    Browse the repository at this point in the history

  16. fix ylabel test failures

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4fc5459 View commit details
    Browse the repository at this point in the history

  17. code simplification

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5ea0327 View commit details
    Browse the repository at this point in the history

  18. fix model_fitting test failures

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    54c65df View commit details
    Browse the repository at this point in the history

  19. ignore multiple slashes warning

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    721ac05 View commit details
    Browse the repository at this point in the history

  20. fix uncertainty unit conversion

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b356b59 View commit details
    Browse the repository at this point in the history

  21. re-introduce resetting y-limits (until can be fixed)

    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    59d1192 View commit details
    Browse the repository at this point in the history

  22. optimize changing spectral y-unit 

    * apply handle_spectral_y_unit before attribute_display_unit
* optimize handle_attribute_display_unit by caching image layers
    @kecnry
    kecnry committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d467ccb View commit details
    Browse the repository at this point in the history