Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated vue file #3195

Merged
merged 1 commit into from
Sep 13, 2024
Merged

updated vue file #3195

merged 1 commit into from
Sep 13, 2024

Conversation

cshanahan1
Copy link
Contributor

Trivial, changed a traitlet name in the vue file to fix aperture phot UI.

@cshanahan1 cshanahan1 added the no-changelog-entry-needed changelog bot directive label Sep 13, 2024
@cshanahan1 cshanahan1 added this to the 4.0 milestone Sep 13, 2024
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Sep 13, 2024
@kecnry kecnry added the trivial Only needs one approval instead of two label Sep 13, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking it down!

@kecnry
Copy link
Member

kecnry commented Sep 13, 2024

(Introduced in #3187 so never made it to a release, no need to backport)

@cshanahan1 cshanahan1 enabled auto-merge (squash) September 13, 2024 16:20
@cshanahan1 cshanahan1 merged commit 9a85af7 into spacetelescope:main Sep 13, 2024
25 checks passed
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (d26971f) to head (38f6cfa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
- Coverage   88.50%   88.50%   -0.01%     
==========================================
  Files         124      124              
  Lines       18448    18448              
==========================================
- Hits        16328    16327       -1     
- Misses       2120     2121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants