Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix specviz2d matched mousover marker #3203

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 26, 2024

Description

This pull request fixes the visibility of the mouseover marker in the 1d spectrum viewer during a mouseover in the 1d spectrum viewer. This was broken by #2830 which now needs to set coords_status = True in cases in which the WCS lookup is successful.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the backport-v3.10.x on-merge: backport to v3.10.x label Sep 26, 2024
@kecnry kecnry added this to the 3.10.4 milestone Sep 26, 2024
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Sep 26, 2024
@kecnry kecnry marked this pull request as ready for review September 26, 2024 17:55
@kecnry kecnry added the trivial Only needs one approval instead of two label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (b4fe650) to head (2d72ee0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   88.50%   88.51%   +0.01%     
==========================================
  Files         124      124              
  Lines       18579    18580       +1     
==========================================
+ Hits        16443    16447       +4     
+ Misses       2136     2133       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camipacifici
Copy link
Contributor

Works for me. Thank you for the fix!

@pllim pllim merged commit fc88465 into spacetelescope:main Oct 1, 2024
25 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 1, 2024
@kecnry kecnry deleted the fix-specviz2d-mouseover-mark branch October 1, 2024 14:46
pllim added a commit that referenced this pull request Oct 1, 2024
…3-on-v3.10.x

Backport PR #3203 on branch v3.10.x (fix specviz2d matched mousover marker)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.10.x on-merge: backport to v3.10.x imviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants