Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mysqlclient version #461

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Change mysqlclient version #461

merged 2 commits into from
Mar 20, 2024

Conversation

hyukychang
Copy link
Contributor

@hyukychang hyukychang commented Mar 18, 2024

mysqlclient 버전 수정..

혹시 리베이스가 필요하다면 말해주세요

버전 변경 이유
local 환경에서 ara setting 시에 mysqlclient가 설치 되지 않음
해당 이슈는 최신 arm 최신 mac os 에서 발생했던거 같고 이 이슈가 2.4.3에서 고쳐짐

고쳐지면서 test 하나가 실패하는 이슈도 같이 발생함, 요거는 매우 중요한 이슈는 아니라서 리팩토링하면서 같이 수정할 예정

PyMySQL/mysqlclient#688
PyMySQL/mysqlclient#687

@injoonH injoonH self-requested a review March 20, 2024 12:51
@hyukychang hyukychang changed the title change mysqlclient Change mysqlclient Mar 20, 2024
@hyukychang hyukychang changed the title Change mysqlclient Change mysqlclient version Mar 20, 2024
@hyukychang hyukychang changed the base branch from master to develop March 20, 2024 12:56
Copy link
Member

@injoonH injoonH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysqlclient 버전 변경한 이유만 간단하게 description에 적어주세요 👍

@hyukychang hyukychang merged commit 4128d41 into develop Mar 20, 2024
1 check passed
@injoonH injoonH deleted the mysql_client_version_update branch March 26, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants