Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle various types of attachments #68

Open
1 of 3 tasks
jwoo0122 opened this issue Sep 20, 2019 · 2 comments
Open
1 of 3 tasks

Handle various types of attachments #68

jwoo0122 opened this issue Sep 20, 2019 · 2 comments
Labels
backend Need backend support. improve New feature, new library, etc.
Milestone
1.2

Comments

@jwoo0122
Copy link
Member

jwoo0122 commented Sep 20, 2019 •
edited
Loading

  • Image
  • Video
  • Binary (text, pdf... lets provide download button)

Not just upload, but we should consider the best way to represent each attachments.
@jwoo0122 jwoo0122 added this to the 1.1 milestone Sep 20, 2019
@jwoo0122 jwoo0122 added improve New feature, new library, etc. and removed enhancement labels Sep 20, 2019
@jwoo0122 jwoo0122 changed the title Attach various types of file. Handle various types of attachments Sep 20, 2019
@jwoo0122 jwoo0122 added new feature backend Need backend support. and removed improve New feature, new library, etc. new feature labels Sep 24, 2019
@apple12347678
Copy link

@jwoo0122 video는 안받는 걸로 합시다. 단순 용량 문제 외에도 (사진도 사실 마찬가지지만) 하나하나 심의할 여력이 안된다고 생각됨. 유튜브 링크 임베딩이 낫지 않을까... 그 외 파일들은 몇가지 화이트리스트 확장자에 대해 헤더의 매직 넘버 값을 확인하여 검증 가능함(현재 백엔드에서 구현 중). 지금 생각나는 화이트리스트는 이정도?

  • .txt
  • .docx, .doc, ... (MS Word)
  • .pptx, .ppt, ... (MS PowerPoint)
  • .pdf
  • .hwp
  • .zip, .7z, ... (tgz, tar, gz 쓰는 사람은 없겠죠) (위험 알림 표시 필수 - 실행파일이 들어있는 경우 즉시 파기)

더 필요한 게 있으면 의견 받아보겠습니다.

@HelloWorld017 HelloWorld017 self-assigned this Nov 7, 2019
This was referenced Nov 11, 2019
Merged
Open
@HelloWorld017 HelloWorld017 removed their assignment Nov 12, 2019
@jwoo0122 jwoo0122 modified the milestones: 1.1, 1.2 Nov 13, 2019
@jwoo0122
Copy link
Member Author

이 티켓은 각각 파일들 미리보기 제공 (ex pdf 미리보기) 등등 advanced 한 기능들 제공하는 티켓으로 하죠

@jwoo0122 jwoo0122 added the improve New feature, new library, etc. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Need backend support. improve New feature, new library, etc.
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@HelloWorld017 @apple12347678 @jwoo0122