Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minimum package version #322

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Fixed minimum package version #322

merged 1 commit into from
Feb 3, 2024

Conversation

thecaliskan
Copy link
Contributor

@thecaliskan thecaliskan commented Feb 2, 2024

The arch function was added with version 2.5.0. @freekmurze

https://github.com/spatie/package-skeleton-laravel/blob/main/tests/ArchTest.php#L3

pestphp/pest-plugin-arch@28519b7

Run vendor/bin/pest --ci

   ERROR  Call to undefined function arch()

Location: /home/runner/work/laravel-stock/laravel-stock/tests/ArchTest.php:3

#0 /home/runner/work/laravel-stock/laravel-stock/vendor/pestphp/pest/overrides/Runner/TestSuiteLoader.php(89): include_once()
#1 /home/runner/work/laravel-stock/laravel-stock/vendor/pestphp/pest/overrides/Runner/TestSuiteLoader.php(92): PHPUnit\Runner\TestSuiteLoader::PHPUnit\Runner\{closure}()
#2 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/Framework/TestSuite.php(244): PHPUnit\Runner\TestSuiteLoader->load()
#3 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/Framework/TestSuite.php(261): PHPUnit\Framework\TestSuite->addTestFile()
#4 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/TextUI/Configuration/Xml/TestSuiteMapper.php(100): PHPUnit\Framework\TestSuite->addTestFiles()
#5 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/TextUI/Configuration/TestSuiteBuilder.php(58): PHPUnit\TextUI\XmlConfiguration\TestSuiteMapper->map()
#6 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/TextUI/Application.php(356): PHPUnit\TextUI\Configuration\TestSuiteBuilder->build()
#7 /home/runner/work/laravel-stock/laravel-stock/vendor/phpunit/phpunit/src/TextUI/Application.php(103): PHPUnit\TextUI\Application->buildTestSuite()
#8 /home/runner/work/laravel-stock/laravel-stock/vendor/pestphp/pest/src/Kernel.php(91): PHPUnit\TextUI\Application->run()
#9 /home/runner/work/laravel-stock/laravel-stock/vendor/pestphp/pest/bin/pest(91): Pest\Kernel->handle()
#10 /home/runner/work/laravel-stock/laravel-stock/vendor/pestphp/pest/bin/pest(99): {closure}()
#11 /home/runner/work/laravel-stock/laravel-stock/vendor/bin/pest(119): include('...')
#12 {main}.

@freekmurze freekmurze merged commit 4928146 into spatie:main Feb 3, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants