Add individual element class to core diagram #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the IndividualElement subclass of Element to the Core diagram. Signed-off-by: Sean Barnum <seanbarnum@gmail.com>
Signed-off-by: Sean Barnum <seanbarnum@gmail.com>
goneall
approved these changes
Dec 10, 2024
bact
approved these changes
Dec 10, 2024
|
@zvr - could you review / merge? Hopefully this still fits in the ISO submission timeframe. |
zvr
approved these changes
Dec 10, 2024
|
The PNG has to also go to the spec repo. |
goneall
added a commit
to spdx/spdx-spec
that referenced
this pull request
Dec 10, 2024
Copies the image from spdx/spdx-3-model#941
I just created spdx/spdx-spec#1161 |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for two very simple changes to the diagrams.
The new IndividualElement subclass of Element is added to the Core diagram in the .drawio diagrams file.
The Core diagram is exported to generate an updated model-Core.png raster image of the Core diagram.