feat: correctly track publishing event errors

speakeasy-api · May 10, 2024 · fc1be89 · fc1be89
1 parent 497a116
commit fc1be89
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/internal/actions/publishEvent.go b/internal/actions/publishEvent.go
@@ -49,9 +49,7 @@ func PublishEvent() error {
 			return processingErr
 		}
 
-		if !strings.Contains(strings.ToLower(os.Getenv("GH_ACTION_RESULT")), "success") {
-			return fmt.Errorf("failure in publishing: %s", os.Getenv("GH_ACTION_RESULT"))
-		}
+		event.Success = strings.Contains(strings.ToLower(os.Getenv("GH_ACTION_RESULT")), "success")
 
 		return nil
 	})

diff --git a/internal/telemetry/telemetry.go b/internal/telemetry/telemetry.go
@@ -129,7 +129,11 @@ func Track(ctx context.Context, exec shared.InteractionType, fn func(ctx context
 	runEvent.LocalCompletedAt = &curTime
 	duration := runEvent.LocalCompletedAt.Sub(runEvent.LocalStartedAt).Milliseconds()
 	runEvent.DurationMs = &duration
-	runEvent.Success = err == nil
+
+	// For publishing events runEvent success is set by publishEvent.go
+	if exec != shared.InteractionTypePublish {
+		runEvent.Success = err == nil
+	}
 	currentIntegrationEnvironment := "GITHUB_ACTIONS"
 	runEvent.ContinuousIntegrationEnvironment = &currentIntegrationEnvironment