feat: track GitHub PRs in CLI events #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogWilco
force-pushed
the
nick/spe-4224-track-generate-github-pr-in-cli-events
branch
from
530d7d2 to
351e81a
Compare
… GH_PULL_REQUEST when present
RogWilco
force-pushed
the
nick/spe-4224-track-generate-github-pr-in-cli-events
branch
from
351e81a to
a081a0d
Compare
ryan-timothy-albert
approved these changes
Oct 14, 2024
RogWilco
commented
Oct 16, 2024
| @@ -124,6 +124,13 @@ func Track(ctx context.Context, exec shared.InteractionType, fn func(ctx context | |||
| // Execute the provided function, capturing any error | |||
| err = fn(ctx, runEvent) | |||
|
|
|||
| // Populate event with pull request env var (available only after run) | |||
There was a problem hiding this comment.
I'm not super excited about having to move this outside EnrichEventWithEnvironmentVariables which otherwise was the perfect place to do this, but short of a more involved refactor this should do the trick.
RogWilco
force-pushed
the
nick/spe-4224-track-generate-github-pr-in-cli-events
branch
from
ac8a40f to
6db8428
Compare
RogWilco
deleted the
nick/spe-4224-track-generate-github-pr-in-cli-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects the GitHub PR URL (when applicable) and adds it to the event telemetry (again when applicable).