-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add main branch tagging from release #189
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3c2a002
feat: add main branch tagging from release
ryan-timothy-albert bb298a5
feat: update
ryan-timothy-albert 2925b76
feat: update
ryan-timothy-albert 794d06f
feat: update
ryan-timothy-albert 92f9f3e
feat: update
ryan-timothy-albert 9b631e4
feat: update
ryan-timothy-albert 91f0374
feat: update
ryan-timothy-albert d3cd3ed
feat: update with newest sdk gen config
ryan-timothy-albert c2a99aa
feat: update
ryan-timothy-albert 7508f39
feat: update
ryan-timothy-albert e41ecd9
feat: update
ryan-timothy-albert c5682b5
feat: update
ryan-timothy-albert debfa17
feat: update
ryan-timothy-albert 9d9f911
feat: update
ryan-timothy-albert 7aa313c
feat: update
ryan-timothy-albert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need sources AND targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just weird naming with the way the underlying tagging lib is currently written. Sources is basically the spec source and targets is codeSamples. I'll leave a comment here