Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need of having nestedNodes inside NodeData #1944

Closed
AlexandruPopovici opened this issue Jan 6, 2024 · 1 comment
Closed

Remove the need of having nestedNodes inside NodeData #1944

AlexandruPopovici opened this issue Jan 6, 2024 · 1 comment
Assignees
@AlexandruPopovici
Labels
[ viewer ] issues related to the 3d viewer package

Comments

@AlexandruPopovici
Copy link
Contributor

Some types of lines use the nestedNodes property, but we need to make it obsolete since it's very outdated
@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Jan 6, 2024
@AlexandruPopovici AlexandruPopovici self-assigned this Jan 6, 2024
@AlexandruPopovici AlexandruPopovici changed the title Remove the nees of having nestedNodes inside NodeData Remove the need of having nestedNodes inside NodeData Jan 6, 2024
@AlexandruPopovici
Copy link
Contributor Author

Can't really make them obsolete since they're actively being used on Polycurves and Curves. We could make nestedNodes "go away" but it would just move the issues someplace else. The real fix here will probably come when/if we refactor traversal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandruPopovici AlexandruPopovici

Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexandruPopovici