Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview-service): listen externally on metrics port #2893

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

iainsproat
Copy link
Contributor

Description & motivation

The preview service application should only listen on localhost, as it currently does. However, the metrics endpoint should be externally accessible (by Prometheus) so should listen on 0.0.0.0 by default. This should be configurable.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat merged commit 206b236 into main Sep 5, 2024
23 of 26 checks passed
@iainsproat iainsproat deleted the iain/fix-preview-service-metrics-server-host branch September 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant