Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurements Units Fixes #3741

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Measurements Units Fixes #3741

merged 4 commits into from
Dec 20, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Dec 20, 2024 •
edited
Loading

Description & motivation

Handles WEB-2311 & WEB-2399

Changes:

  • Measurement's update function now returns Promise<void> because it may contain a text which can only be updated asynchronous because of how troika-text (the library we use for text rendering) works
  • Corrects units and precision are being set when a new measurement is created

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici
Handles new measurements reverting to meters even if a different unit…
33ebcd1 
… was previously set. Handles units not changing properly when changing the unit value
@linear Linear
Copy link

linear bot commented Dec 20, 2024

WEB-2399 MeasurementTool, units do not update properly

WEB-2311 Measurement Tool, units resets to meters incorrectly

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

Mikehrn
Mikehrn previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Mikehrn Mikehrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 Tested it in FE and also worked as expected

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

andrewwallacespeckle
andrewwallacespeckle previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that all bugs are fixed

@github-actions GitHub Actions
Copy link
Contributor

📸 Preview service has generated an image.

@andrewwallacespeckle andrewwallacespeckle merged commit b337ae3 into main Dec 20, 2024
28 of 30 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the alex/WEB-2399-WEB-2311 branch December 20, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle approved these changes

@Mikehrn Mikehrn Mikehrn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandruPopovici @Mikehrn @andrewwallacespeckle