feat(server): logging stack traces for db errors + allow async stack traces through env var #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traces through env var
|
📸 Preview service has generated an image. |
gjedlicska
approved these changes
Jan 14, 2025
iainsproat
reviewed
Jan 14, 2025
| @@ -194,6 +194,9 @@ db: | |||
| ## @param db.connectionCreationTimeoutMillis The maximum time in milliseconds to wait for a new connection to be created in the connection pool. Should be less than the acquisition timeout, as a new connection may need to be created then acquired. | |||
| ## | |||
| connectionCreationTimeoutMillis: 5000 | |||
| ## @param db.knexAsyncStackTracesEnabled If enabled, will provide better stack traces for errors arising out of knex operations | |||
There was a problem hiding this comment.
I'd nest this, like so:
knexAsyncStackTraces:
enabled: false
It allows us for more flexibility later, should we wish to append any more configuration.
There was a problem hiding this comment.
@iainsproat gergo already merged it, but in any case I'm not aware of any other configuration options relating to async stack traces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: judging from my testing we might not even need to enable async stack traces in prod, the stack trace still seems to provide a clue to which repo fn triggered the operation