Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output lookml results as json #737

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Output lookml results as json #737

wants to merge 2 commits into from

Conversation

nickdeis
Copy link

@nickdeis nickdeis commented Nov 18, 2023 •
edited
Loading

Change description

Adds the flag --json, that allows you to output lookml results as raw json

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Security

  • Security impact of change has been considered
  • Code follows security best practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer

@joshtemple
Copy link
Collaborator

Hey @nickdeis, thanks for this! Could you expand this so the --json option works for all subcommands? (e.g. spectacles sql, spectacles content, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanBaker DylanBaker Awaiting requested review from DylanBaker DylanBaker is a code owner

@joshtemple joshtemple Awaiting requested review from joshtemple joshtemple is a code owner

@Hawk94 Hawk94 Awaiting requested review from Hawk94 Hawk94 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdeis @joshtemple