-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support newer versions of sphinx #46
base: master
Are you sure you want to change the base?
Conversation
StandaloneHTMLBuilder.default_sidebars was removed in sphinx ~1.6. sphinx-doc/sphinx@e8e63b1#diff-c17608ed63bfe1714c6befb9d4201fee
Tests appeared to start failing with my change. Realized that some test or users may be relying on the pre-1.6 default_sidebars behavior, threw in an EAFP.
Fixing linter error.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 99.01% 98.45% -0.56%
==========================================
Files 9 8 -1
Lines 910 909 -1
Branches 178 176 -2
==========================================
- Hits 901 895 -6
- Misses 4 7 +3
- Partials 5 7 +2
Continue to review full report at Codecov.
|
@Robpol86 I can't grok how so many more tests in appveyor began failing with this change, and they seem unrelated to what I did. Also don't understand the coverage decrease for files other than sphinx_.py. Assigning to you anyways for merge? |
👍 @Lingnik Thank you for the fix. I installed your branch and everything worked as expected. |
@Robpol86, please merge this PR :) |
@Robpol86, any updates on this PR? |
@Robpol86 mind merging this one? If you don't maintain the repository anymore - please let someone else (e.g. one of the already existing contributors) take over. |
@Robpol86 also affected by this one - please merge |
to install patched version pip install -U git+https://github.com/Lingnik/sphinxcontrib-versioning@Lingnik-patch-1 |
Hi guys, is |
@zhanghang1989, In my project I have C++-extension module, so I need install to properly generate module API with autodoc. pip install -U git+https://github.com/sizmailov/sphinxcontrib-versioning@conditionally_run_setup_py |
This change seems to remove entirely the default sidebars for me - I just end up with the versions in the side bar, but when building standalone I get a TOC and a few others. |
StandaloneHTMLBuilder.default_sidebars was removed in sphinx ~1.6. sphinx-doc/sphinx@e8e63b1 Fixes sphinx-contrib#36
StandaloneHTMLBuilder.default_sidebars was removed in sphinx ~1.6. sphinx-doc/sphinx@e8e63b1 sphinx-contrib#39
StandaloneHTMLBuilder.default_sidebars was removed in sphinx ~1.6.
sphinx-doc/sphinx@e8e63b1#diff-c17608ed63bfe1714c6befb9d4201fee
Fixes #39