Spinx 1.7+ ImportError workaround #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-hack
reviewed
Nov 18, 2019
|
@paddy-hack thanks for clarification. So you closing the PR? |
|
No, I'm not closing this PR. I'm just suggesting you fix up the comment in this/your PR so people looking at the code later don't get misled. That's all. See #70 (comment) for some background info on this. |
z00sts
changed the title
|
Can yo control-merge master into your branch/rebase, @z00sts? Also, if I understand it correctly, updating |
|
I updated branch state with upstream and created new PR with correct branch-name and commit message #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you at least see application help instead of Traceback print.
Fixes #66