-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sphinx1.7+: ImportError workaround, allows to see help #78
base: master
Are you sure you want to change the base?
sphinx1.7+: ImportError workaround, allows to see help #78
Conversation
13272ee
to
221a1c7
Compare
Can you fix the linting error:
|
221a1c7
to
d6d0260
Compare
@TimKam fixed |
@TimKam any progress on this one? |
@TimKam there is a good number of users who would love to this merged (and released!) :) |
Sorry, my GitHub inbox is so full that I can hardly see what's relevant. I'll take a look tomorrow night latest. |
I am getting an error:
I cannot see where in the code |
I'm not sure that this particular issue is related |
I am also not sure, but I cannot successfully do a manual test. If you point me to a doc set that should "just work" with this branch, I'll test it and consider it good enough/create a follow-up issue. |
I had these issues, too, and decided to write a new, clean implementation of a sphinx versioning extension. If you're still having problems with this, you could try https://holzhaus.github.io/sphinx-multiversion/master/index.html |
@Holzhaus great, wouldn't it make sense to consolidate these two projects? I.e. if your extension has the same functionality as this one but works reliably, we can deprecate this extension and ideally move yours into this GitHub project (but you remain maintainer). What do you think? |
The extension works vastly different internally. Check the FAQ page. I wrote it to add versioning to the existing sphinx documentation of the Mixxx DJ Software. Hence, I made sure does not require any changes to old branches/tags (i.e. adding the extension to I suggest you try it out first before we start to talk about dropping |
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 98.34% 98.46% +0.11%
==========================================
Files 8 8
Lines 908 912 +4
Branches 176 176
==========================================
+ Hits 893 898 +5
Misses 7 7
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
Any progress on this? What's holding it up from being merged in? |
upstream merged + branch/commit renamed (#69)
UPD: add reproduce details
python 3.7.5