Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Builder inherit from abc.ABC #12996

Open
AA-Turner opened this issue Oct 10, 2024 · 0 comments
Open

Make Builder inherit from abc.ABC #12996

AA-Turner opened this issue Oct 10, 2024 · 0 comments
Labels
builder internals:refactoring

Comments

@AA-Turner
Copy link
Member

Should we make Builder an https://docs.python.org/3/library/abc.html#abc.ABC class, with @abstractmethod rather than using raise NotImplementedError?

Originally posted by @chrisjsewell in #12767 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builder internals:refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Builder a subclass of abc.ABC AA-Turner/sphinx
1 participant
@AA-Turner