Allow --pdb option to also debug warnings #12727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
fix-pdb-pending-warnings
branch
from
11e1a85
to
de19354
Compare
jayaddison
added
type:enhancement
picnixz
reviewed
Aug 5, 2024
jbms
force-pushed
the
fix-pdb-pending-warnings
branch
from
de19354
to
9954c49
Compare
Added a test. |
picnixz
reviewed
Aug 6, 2024
jbms
force-pushed
the
fix-pdb-pending-warnings
branch
from
9954c49
to
ed86a6e
Compare
Previously, warnings emitted during reading and writing were deferred, which made --pdb ineffective for debugging them. With this change, warnings are no longer deferred when --pdb and --fail-on-warning are both specified.
jbms
force-pushed
the
fix-pdb-pending-warnings
branch
from
ed86a6e
to
b318a66
Compare
|
Closing, as I believe that this is covered by #12743. Happy to reopen if I'm wrong, though. A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Previously, warnings emitted during reading and writing were deferred, which made --pdb ineffective for debugging them.
With this change, warnings are no longer deferred when --pdb and --fail-on-warning are both specified.