-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow figure dash and en dash as year separator in copyright #12738
Allow figure dash and en dash as year separator in copyright #12738
Conversation
These are valid characters to denote ranges.
Mh, I don't quite understand why the unicode dash is not preserved in the generated html it should hit this codepath:
but apparently it doesn't. I'm having some issues running the testsuite, so any help/pointers would be appreciated.
but I can
|
Hi @fortysixandtwo! I attempted something similar recently (except without figure-dash support) in #12450 -- although discarded that after learning that some projects are intentonally using non-hyphen dashes for a workaround that it provides: it disables the copyright-year substitution on their I don't think it'd be great to merge this if we know it's going to break their workflows -- but I do also agree in theory that it'd be nice to support other forms of year-range separator. Most of the notes and ideas I've taken about this are in #12451 -- I'd warn that there's a lot of me rambling to myself as I worked through the details, and the conclusions that I did reach have not yet resulted in any merged pull requests. If you have any time to add commentary / suggestions I'd be grateful - it's good to know that someone else cares about and is reading into this. I don't want to be obstructive, and other maintainers could overrule me, but I do think that this change (although well-intentioned) would cause problems for some folks. |
Closing per @jayaddison's rationale. A |
These are valid characters to denote ranges.
I've came across this as an reproducibility issue here