Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: migrate JavaScript tests from karma to jasmine framework #12754

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

  • Migrate from the deprecated karma JavaScript test framework to maintained jasmine equivalents.

Detail

  • Update package.json dependencies -- remove karma, add jasmine dependencies.
  • Use npx jasmine-browser-runner init to initialize the project, and migrate relevant karma.conf.js settings.
  • Update the GitHub Actions workflows accordingly.
  • No modifications to unit tests, fixtures, or application JavaScript code.

Relates

@AA-Turner AA-Turner merged commit e323826 into sphinx-doc:master Aug 9, 2024
20 checks passed
@jayaddison
Copy link
Contributor Author

Thanks @AA-Turner!

@jayaddison jayaddison deleted the issue-12141/js-tests-migrate-karma-to-jasmine branch August 10, 2024 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
@AA-Turner AA-Turner added this to the 8.1.x milestone Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: consider migration from karma-runner to jasmine-browser-runner.
2 participants