Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the type annotation for sphinx.testing.fixtures.rootdir #12764

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix the type annotation for sphinx.testing.fixtures.rootdir #12764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5847b6
tweak: rootdir expects pathlib.Path
ftnext Aug 11, 2024
b82dcb9
Update sphinx/testing/fixtures.py
AA-Turner Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sphinx/testing/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def pytest_configure(config: pytest.Config) -> None:


@pytest.fixture(scope='session')
def rootdir() -> str | None:
def rootdir() -> Path | None:
return None


Expand Down Expand Up @@ -74,7 +74,7 @@ def app_params(
test_params: dict[str, Any],
shared_result: SharedResult,
sphinx_test_tempdir: str,
rootdir: str,
rootdir: Path,
) -> _app_params:
"""
Parameters that are specified by 'pytest.mark.sphinx' for
Expand Down