Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom assigning workflow #1028

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented Dec 19, 2023

Our current action is now deprecated as it is using node12, so replacing with our own should improve these matters and our control over the workflow.

glaze

Okay, it is now fully working I believe 👌

@afonsojramos afonsojramos force-pushed the feat/update-assign-on-theme-workflow branch from 4f62441 to 361283c Compare December 19, 2023 14:46
@theRealPadster
Copy link
Member

My only note would be that we might get false positives for the "Default" one, but that's kind of unavoidable.

@afonsojramos
Copy link
Member Author

afonsojramos commented Dec 19, 2023

My only note would be that we might get false positives for the "Default" one, but that's kind of unavoidable.

@theRealPadster Well, yeah 😥 But that was already expected. We can always remove that entry if we feel like it is affecting it too much, but for now I tried to maintain functionality.

@afonsojramos afonsojramos changed the title feat: use our own assigning workflow feat: custom assigning workflow Dec 19, 2023
@afonsojramos afonsojramos merged commit 27cafff into master Dec 19, 2023
1 check passed
@afonsojramos afonsojramos deleted the feat/update-assign-on-theme-workflow branch December 19, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants