Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor derivatives naming convention #157

Closed
sandrinebedard opened this issue Feb 8, 2024 · 9 comments · Fixed by #159
Closed

Refractor derivatives naming convention #157

sandrinebedard opened this issue Feb 8, 2024 · 9 comments · Fixed by #159
Assignees

Comments

@sandrinebedard
Copy link
Member

sandrinebedard commented Feb 8, 2024

Description

Since we have now clarified the naming of the labels in the derivatives, we need to update the derivatives name in spine generic

Suggestions

  • sub-amu01_T2star_seg-manual.nii.gz --> sub-amu01_T2star_label-SC_seg.nii.gz
  • sub-amu01_T2w_labels-disc-manual.nii.gz --> sub-amu01_T2w_label-discs_dlabel.nii.gz
  • sub-amu01_T1w_softseg.nii.gz --> sub-amu01_T1w_label-SC_softseg.nii.gz
  • sub-amu01_T1w_softseg_bin.nii.gz --> sub-amu01_T1w_desc-softseg_label-SC_seg.nii.gz (to be discussed)
  • sub-amu01_T1w_csfseg-manual.nii.gz --> sub-amu01_T1w_label-CSF_seg.nii.gz
  • For discs warped from T2w: sub-amu01_T2w_label-discs_desc-warp_dlabel.nii.gz
  • _RPI_r_labels-manual --> space-other_T2w_label-vertebrae_desc-C2C5_dlabel
  • gmseg --> label-GM_seg

Note: do we want to add the discs labels from warping from T2w for the other contrasts inside the derivatives? (as we do and need for the contrast-agnostic project)

Related issues

#156
#154
#141

TODO

  • Update all preprocessing scripts with new name convention
@sandrinebedard sandrinebedard self-assigned this Feb 8, 2024
@sandrinebedard
Copy link
Member Author

@jcohenadad
Copy link
Member

image

Looks good to me! (i'm copy/pasting in case the issue text changes in the future)

Note: do we want to add the discs labels from warping from T2w for the other contrasts inside the derivatives? (as we do and need for the contrast-agnostic project)

I would say yes, so that the contrast-agnostic model can more easily be reproduced, no?

@naga-karthik
Copy link

so that the contrast-agnostic model can more easily be reproduced, no?

Yes! We required the disc labels for vertebral labeling and the C2-C3 CSA computation via sct_process_segmentation. Hence, adding the disc labels would be good!

@sandrinebedard
Copy link
Member Author

@NathanMolinier

We have some disc labels that are warped from the T2w, but we want to add them in the derivatives 2 (BUT THEY MAY NOT BE PERFECT) and we do not want to be confused between them and manual disc labels, do you have a suggetsion?

@jcohenadad
Copy link
Member

We should also add the space-other field #156

@sandrinebedard
Copy link
Member Author

I noticed that the disc labels in the derivatives are in the original space LPI, should I reorient them and add space-other to be consitent? or do we keep them in the original space?

@NathanMolinier
Copy link
Contributor

We should also add the space-other field #156

Or space-warp but we need to add this to the JSON sidecar as well to say that the image was warped from another contrast

@NathanMolinier
Copy link
Contributor

I noticed that the disc labels in the derivatives are in the original space LPI, should I reorient them and add space-other to be consitent? or do we keep them in the original space?

Therefore, do we need to store 2 versions of the discs labels ?

@sandrinebedard
Copy link
Member Author

reorientation is a very simple step, I don't think we need 2 versions (in the contrast-agnsotic pipeline, sct_label_vertebrae reorients in any case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants