Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move derivatives from spine-generic-processed #123

Merged
merged 18 commits into from
Aug 30, 2022
Merged

Conversation

sandrinebedard
Copy link
Member

@sandrinebedard sandrinebedard commented Jul 8, 2022

Context

Currenlty, we have a processed version of this dataset (spine-generic-processed) where we have derivatives, but some are duplicated. See #121.

This PR moves the derivatives from spine-generic-processed to data-multi-subjects.

The derivatives are now BIDS compatible, they inlcude:

Related issues

fixes #121

What is missing

@sandrinebedard
Copy link
Member Author

@mguaypaq , could you take a look at the PR. Thank you!

@mguaypaq mguaypaq self-requested a review August 1, 2022 15:51
@mguaypaq
Copy link
Member

mguaypaq commented Aug 1, 2022

Sure, I'm pretty busy today but I'll take a look tomorrow.

@sandrinebedard
Copy link
Member Author

I had some extra modifications to add, but I was unable to push to git annex:

(base) sebeda@joplin:~/data_nvme_sebeda/data-multi-subject/derivatives/labels/sub-perform02$ git push origin git-annex:git-annex
Username for 'https://github.com': sandrinebedard
Password for 'https://sandrinebedard@github.com':
To https://github.com/spine-generic/data-multi-subject
 ! [rejected]            git-annex -> git-annex (non-fast-forward)
error: failed to push some refs to 'https://github.com/spine-generic/data-multi-subject'
hint: Updates were rejected because a pushed branch tip is behind its remote
hint: counterpart. Check out this branch and integrate the remote changes
hint: (e.g. 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details

@kousu
Copy link
Contributor

kousu commented Aug 2, 2022

@sandrinebedard please try

git annex sync --no-content --only-annex --cleanup # upload mirror contents
git push

The wiki docs seem to have had a bad merge at some point (this point). The last step, git push origin git-annex:git-annex, is redundant. And also impossible, it turns out, if you're collaborating with others who've also been uploading to the annex.

The lab manual docs have the same instructions but without the final step. I've updated the wiki to match.

@sandrinebedard
Copy link
Member Author

Thanks @kousu ! It seams t have worked!

@sandrinebedard
Copy link
Member Author

@mguaypaq I will need finally to modify some extra data. I think you can wait to check this PR until then. I'll ping you when it's ready!

@sandrinebedard
Copy link
Member Author

Hello @mguaypaq ! I've finished the extra modification, you can now take a look, thank you!

@mguaypaq
Copy link
Member

It looks like the following 45 files are missing from amazon:

derivatives/labels_softseg/sub-beijingGE02/anat/sub-beijingGE02_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingGE02/anat/sub-beijingGE02_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-beijingGE02/anat/sub-beijingGE02_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingGE02/dwi/sub-beijingGE02_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio01/anat/sub-beijingVerio01_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio01/anat/sub-beijingVerio01_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio01/anat/sub-beijingVerio01_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio02/anat/sub-beijingVerio02_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio02/anat/sub-beijingVerio02_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio02/anat/sub-beijingVerio02_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio03/anat/sub-beijingVerio03_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio03/anat/sub-beijingVerio03_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio03/anat/sub-beijingVerio03_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-beijingVerio03/dwi/sub-beijingVerio03_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-ubc01/anat/sub-ubc01_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ubc01/anat/sub-ubc01_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ubc01/anat/sub-ubc01_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ubc01/anat/sub-ubc01_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ubc01/dwi/sub-ubc01_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-ubc03/anat/sub-ubc03_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ubc03/anat/sub-ubc03_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ubc03/anat/sub-ubc03_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ubc05/anat/sub-ubc05_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ubc05/anat/sub-ubc05_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ubc05/anat/sub-ubc05_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ubc05/anat/sub-ubc05_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ubc05/dwi/sub-ubc05_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis03/anat/sub-ucdavis03_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis03/anat/sub-ucdavis03_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis03/anat/sub-ucdavis03_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis03/anat/sub-ucdavis03_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis03/dwi/sub-ucdavis03_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis05/anat/sub-ucdavis05_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis05/anat/sub-ucdavis05_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis05/anat/sub-ucdavis05_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis05/anat/sub-ucdavis05_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis05/dwi/sub-ucdavis05_rec-average_dwi_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis06/anat/sub-ucdavis06_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis06/anat/sub-ucdavis06_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis06/anat/sub-ucdavis06_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis06/anat/sub-ucdavis06_T2w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis07/anat/sub-ucdavis07_acq-MTon_MTS_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis07/anat/sub-ucdavis07_T1w_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis07/anat/sub-ucdavis07_T2star_softseg.nii.gz
derivatives/labels_softseg/sub-ucdavis07/anat/sub-ucdavis07_T2w_softseg.nii.gz

The file metadata already exists on your branch sb/121-move-derivatives, so it should be enough to upload the file contents to amazon and update the git-annex branch, like this (taken from step 6 of the wiki instructions):

git annex enableremote amazon public=no
git annex copy derivatives/labels_softseg/sub-{beijingGE02,beijingVerio01,beijingVerio02,beijingVerio03,ubc01,ubc03,ubc05,ucdavis03,ucdavis05,ucdavis06,ucdavis07}/*/*.nii.gz --to amazon
git annex enableremote amazon public=yes
git annex sync --no-content --only-annex

@sandrinebedard
Copy link
Member Author

OK I've added them to amazon!

Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since data validation passes, and this (giant) PR is mostly about moving files from another dataset back into this repository, I'm going to approve and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move derivatives from spine-generic-processed back to data-multi-subject
3 participants